Pedestal fixes3 #1492
Merged
Pedestal fixes3 #1492
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This alters user-facing behavior and thus needs a changelog |
ab9rf
approved these changes
Aug 19, 2025
|
I'm going to take the slight risk of merging this for release without acceptance testing since it's a straightforward bug fix |
|
Thanks! So GitHub doesn't carry per-commit comments along when it transfers commits to a merge. There's not even an indication that the comments exist. I don't like that. I would guess that's because the comments are not core Git. Edit: I just bet that the comments will disappear when I delete that branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two minor fixes to
internal/common/pedestal.lua. No user-visible changes, except that removing items from a pedestal using the DFHack interface will work correctly.Well-tested. Extensive comments in each commit.