Change cascading of most 'restrict' foreign keys #2658
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmcj
reviewed
Aug 25, 2024
vmcj
reviewed
Aug 25, 2024
tuupke
force-pushed
the
cascading-some-keys
branch
from
3bd3df2 to
188d007
Compare
nickygerritsen
approved these changes
Aug 25, 2024
|
Did quite a few checks in the ui and most important things appeared to be working. Simply some names that disappeared (as expected). This is also when the issue of deleting users resulting in submissions being deleted showed itself. |
tuupke
force-pushed
the
cascading-some-keys
branch
from
188d007 to
038fd3d
Compare
vmcj
approved these changes
Aug 25, 2024
Checked all remaining foreign keys using:
```
SELECT
rc.DELETE_RULE, rc.UPDATE_RULE,
kcu.TABLE_NAME, kcu.COLUMN_NAME, kcu.CONSTRAINT_NAME, kcu.REFERENCED_TABLE_NAME, kcu.REFERENCED_COLUMN_NAME
FROM
INFORMATION_SCHEMA.KEY_COLUMN_USAGE kcu
INNER JOIN information_schema.REFERENTIAL_CONSTRAINTS AS rc ON kcu.CONSTRAINT_NAME = rc.CONSTRAINT_NAME
WHERE
kcu.REFERENCED_TABLE_SCHEMA = 'domjudge'
AND DELETE_RULE = 'RESTRICT';
```
After some discussion with Jaap it was decided to set columns referring
to judgedaemons to null instead of cascading the delete. A single
foreign key's delete rule is kept as 'restrict' since that case looks to
be sensible.
Fixes DOMjudge#2464, DOMjudge#2465.
The old foreign key was set to cascade, deleting the entire submission when a user got deleted. This feels conceptually wrong since a submission is connected to a team and not to a user. The user of the team of the submission is more 'metadata' than anything else.
tuupke
force-pushed
the
cascading-some-keys
branch
from
038fd3d to
acdabd1
Compare
|
Made it a bit clearer how the migration for |
vmcj
approved these changes
Aug 25, 2024
This was referenced Aug 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #2465, most of the foreign keys who's delete action was set to restrict could have this clause set to either 'cascade' or 'restrict'.
While working on this issue it appeared that deleting a user resulted in deleting of submissions of that team. This has been changed as well. Deleting a team will now simply set the relevant submissions'
useridattribute tonull.There might be other cases similar to the user deletion but these have not been looked at.