preg_match_all always returns an array of arrays #2668
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickygerritsen
approved these changes
Sep 1, 2024
meisterT
reviewed
Sep 1, 2024
There was a problem hiding this comment.
After reading https://www.php.net/manual/en/function.preg-match-all.php#refsect1-function.preg-match-all-returnvalues my suggestion is to capture the return value and check it as well.
from the commit message: |
meisterT
approved these changes
Sep 1, 2024
Even if we cannot match anything we would have had an array containing an empty array. That array indicates that nothing was matched. We should now fail when: - preg_match_all fails - preg_match_all returns it found 0 matches - the redundant case (as safeguard) when the array has 0 matches
vmcj
force-pushed
the
quick_fix_phpstan_bool
branch
from
e9c8fde to
31fcfff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even if we cannot match anything we will have an array containing an empty array. That array indicates that nothing was matched.
Hopefully this fixes what #2665 tried to do.