Skip to content

Simplify submission page and re-order information in a better way. #2672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 8, 2024
Merged

Simplify submission page and re-order information in a better way. #2672

merged 1 commit into from
Sep 8, 2024

Conversation

meisterT
Copy link
Member

@meisterT meisterT commented Sep 7, 2024

Before:
image

After:
image

Another after example:
image

eldering
eldering approved these changes Sep 7, 2024
View reviewed changes
Copy link
Member

@eldering eldering left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Github is not great at showing moved code in a great way, but I trust you just moved things around. LGTM as far as I can see.

@nickygerritsen
Copy link
Member

Same. It looks good so probably fine

@meisterT meisterT added this pull request to the merge queue Sep 8, 2024
Merged via the queue into DOMjudge:main with commit c014fd4 Sep 8, 2024
24 of 25 checks passed
@meisterT meisterT deleted the reordersubpage branch September 8, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickygerritsen nickygerritsen nickygerritsen approved these changes

@eldering eldering eldering approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@meisterT @nickygerritsen @eldering