Skip to content

Update azure-webapps-node.yml #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 16, 2025
Merged

Update azure-webapps-node.yml #10

merged 1 commit into from
Jun 16, 2025

Conversation

Dargon789
Copy link
Owner

@Dargon789 Dargon789 commented Jun 16, 2025

Summary by Sourcery

Enhancements:

  • Fix indentation of the lock file check script block in the GitHub Actions workflow for azure-webapps-node

Signed-off-by: AU_gdev_19 <64915515+Dargon789@users.noreply.github.com>
Copy link
Contributor

sourcery-ai bot commented Jun 16, 2025

Reviewer's Guide

This PR fixes indentation in the ‘Check for lock file’ step of the Azure Web Apps Node.js GitHub Actions workflow so that the multiline shell conditional under ‘run: |’ is parsed and executed correctly.

Flowchart: Logic of 'Check for lock file' Script

graph TD
    Start["Start 'Check for lock file' script"] --> CheckLockfiles{"'package-lock.json' OR 'yarn.lock' exists?"};
    CheckLockfiles -- "No (Neither present)" --> ReportError["echo 'Error: No lock file found!'"];
    ReportError --> ExitError["exit 1"];
    CheckLockfiles -- "Yes (At least one present)" --> ScriptSuccess["Script step completes successfully"];
Loading

File-Level Changes

Change Details Files
Properly aligned the multiline shell script under the run directive in the lock file check step
  • Indented the ‘run:
’ block to match workflow syntax
  • Aligned the ‘if [ ! -f package-lock.json … ]’ line under the run block
  • Moved the ‘fi’ closure to the same indentation level as the ‘if’

  • Tips and commands

    Interacting with Sourcery

    • Trigger a new review: Comment @sourcery-ai review on the pull request.
    • Continue discussions: Reply directly to Sourcery's review comments.
    • Generate a GitHub issue from a review comment: Ask Sourcery to create an
      issue from a review comment by replying to it. You can also reply to a
      review comment with @sourcery-ai issue to create an issue from it.
    • Generate a pull request title: Write @sourcery-ai anywhere in the pull
      request title to generate a title at any time. You can also comment
      @sourcery-ai title on the pull request to (re-)generate the title at any time.
    • Generate a pull request summary: Write @sourcery-ai summary anywhere in
      the pull request body to generate a PR summary at any time exactly where you
      want it. You can also comment @sourcery-ai summary on the pull request to
      (re-)generate the summary at any time.
    • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
      request to (re-)generate the reviewer's guide at any time.
    • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
      pull request to resolve all Sourcery comments. Useful if you've already
      addressed all the comments and don't want to see them anymore.
    • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
      request to dismiss all existing Sourcery reviews. Especially useful if you
      want to start fresh with a new review - don't forget to comment
      @sourcery-ai review to trigger a new review!

    Customizing Your Experience

    Access your dashboard to:

    • Enable or disable review features such as the Sourcery-generated pull request
      summary, the reviewer's guide, and others.
    • Change the review language.
    • Add, remove or edit custom review instructions.
    • Adjust other review settings.

    Getting Help

    Copy link

    Dependency Review

    ✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

    Scanned Files

    None

    @Dargon789 Dargon789 merged commit 47e67db into master Jun 16, 2025
    4 checks passed
    @Dargon789 Dargon789 deleted the Dargon789-patch-1 branch June 16, 2025 09:08
    Copy link
    Contributor

    @sourcery-ai sourcery-ai bot left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Hey @Dargon789 - I've reviewed your changes and they look great!


    Sourcery is free for open source - if you like our reviews please consider sharing them ✨
    Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    1 participant