This repository was archived by the owner on Jun 22, 2025. It is now read-only.
Large response outofmem fix #564
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Greetings. Thank you for your contribution. Can you add a test for this exception handling? (e.g. using mocking) |
| try | ||
| { | ||
| await response.Content.LoadIntoBufferAsync(4096); | ||
| var stream = (MemoryStream)await response.Content.ReadAsStreamAsync(); |
There was a problem hiding this comment.
What is the cast to MemoryStream for?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got a situation when my multi-GB response that I was reading asynchronously got interrupted with an error code. But unfortunately, the library attempts to deserialize the entire response in memory during
ReadAsStringAsynchoping to obtain error text, which results in OOM.The fix employs fixed length buffer to do the same and falls back to a pre-arranged exception in case something goes wrong.