Feat/add chandra images#1411

Open

rz-wang wants to merge 307 commits intoUnitTests/NeateningAndFormalisingfrom

feat/addChandraImages

This pull request is big! We're only showing the most recent 250 commits

Commits on Mar 1, 2025

Fixed the error callback in ciao_call (I hope) - the error that was being thrown by the execute_cmd was just a good old fashioned Python error (not from the product) and so looking for the ' is ass…
DavidT3
committed
Made sure there is a telescope entry in the extra_info dictionary from chandra_image_expmap, and also added the other two output product types to the sources_types list that is returned
DavidT3
committed
Added an XGADeveloperError exception class
DavidT3
committed
Started setting up execute_cmd to be able to handle multiple output files loaded into multiple output products. For issue #1264
DavidT3
committed
Altering get_queue so that it'll handle the possibility of multiple different products output from one command a little better. For issue #1264
DavidT3
committed
Altering get_queue
DavidT3
committed
Trying to make the get queue method work properly with single product types as well as lists of product types
DavidT3
committed
Flattening the expected product types array so that it'll have the same format whether it is for one product type or many.
DavidT3
committed
Restoring chandra_image_expmap sources_types back to how they should be, with multiple entries. For issue #1264
DavidT3
committed
Stopped ciao_call making the (possible list) of ptypes into a string. For issue #1264 (indirectly)
DavidT3
committed
So making the types come through properly into all_type didn't translate into being passed into the execute_cmd function properly - trying a fix.
DavidT3
committed
Didn't import numpy - PyCharm code inspection is really ropey recently
DavidT3
committed
Added a section to execute cmd for produced ratemap files (like fluximage does for Chandra) which just continues (XGA will produce a ratemap itself) - but this should change eventually I feel. Rele…
DavidT3
committed
I may have made the execute_cmd work with multiple products with different types produced by a single function! It should also provide returns that are compatible with the existing states of sas_ca…
DavidT3
committed
For some reason the ciao_call product-assignment-to-source bit might already be able to deal with multiple products in the returned 'results' dictionary (containing the set up product instances). I…
DavidT3
committed
Spoke to soon about execute_cmd
DavidT3
committed
Making sure the output product paths are in a LIST or a string, not an array as I was allowing before
DavidT3
committed
Now getting a FileNotFoundError when declaring the image I think? Trying to diagnose
DavidT3
committed
Bowed to expediency by currently changing the image_file, expmap_file, etc. that Ray sets up in the chandra_image_expmap function to the stupidly formatted names that fluximage comes out with. For …
DavidT3
committed
Urgh
DavidT3
committed
I messed up the temporary name formatting in chandra_image_expmap - might work now.
DavidT3
committed
.
DavidT3
committed
Hopefully made the assignment of multiple products from a single function run work. For issue #1264
DavidT3
committed
Was defining a variable (all_type) as an empty list INSIDE a loop, so it was wiping it each iteration. Hopefully fixing this will make image generation work for sources with multiple Chandra ObsIDs…
DavidT3
committed
Put in some diagnostics and tried moving the last lines of chandra_image_expmap up one level of indent, I think they were being set too earlier. For issue #1264
DavidT3
committed
Nope it was right already
DavidT3
committed
Commented out the decorator
DavidT3
committed
Restored the decorator
DavidT3
committed
The problem is in how I changed update_queue - the flatten().to_list() bit applied to the queue type works fine with a single ObsID and a single or multiple expected output types, but it doesn't wo…
DavidT3
committed
Alright - trying to make the chandra_image_expmap function work with single and multiple obs, and with single and multiple expected output products.
DavidT3
committed
Alright - trying to make the chandra_image_expmap function work with single and multiple obs, and with single and multiple expected output products.
DavidT3
committed
Small change to execute_cmd, trying to convert np arrays into lists if necessary.
DavidT3
committed
Fixed the execute command function, now works for multiple ObsIDs. For issue #1264
DavidT3
committed
Fixed the execute command function, now works for multiple ObsIDs. For issue #1264
DavidT3
committed

Commits on Mar 3, 2025

Commits on Mar 4, 2025

Changed one word of the error message that can be thrown in snr_ranking and count_ranking.
DavidT3
committed

Commits on Mar 5, 2025

Commits on Mar 7, 2025

Commits on Mar 10, 2025

Commits on Mar 11, 2025

Commits on Mar 12, 2025

Commits on Mar 13, 2025

Commits on Mar 20, 2025

Commits on Mar 21, 2025

Commits on Mar 25, 2025

Commits on Mar 26, 2025

Commits on Apr 3, 2025

Commits on Apr 10, 2025

Commits on Apr 11, 2025

Commits on Apr 12, 2025

Commits on Apr 14, 2025

Commits on Jul 1, 2025

Added a new function to the LT pipeline that modifies the core_excised parameter, ensuring that specextraction follows core_excised during iteration and defaults to core_excised in the final run. I…
rz-wang
committed

Commits on Jul 8, 2025

Commits on Jul 31, 2025

Removed the "luminosity_temperature_pipeline" function for testing (#1358)
rz-wang
committed

Commits on Aug 4, 2025

Commits on Aug 7, 2025

I cleaned up the testing functions and removed unnecessary comments. I also marked those conversations as resolved, as I don't think they need to remain open under PR (#1413)
rz-wang
committed

Commits on Aug 13, 2025

Added a few comments (#1413)
rz-wang
committed

Commits on Aug 18, 2025

Added some comments (#1413)
rz-wang
committed