refactor

[Testudinidae]

Refactor / Naming / Consistency

• Renamed Resources keys from “code-oriented” to “UI-oriented” to avoid ambiguous keys.
• Refactored OpenHomePage logic: OpenHomePageCommand and SearchWebCommand are now used the same way.
• Renamed SearchCommand → SearchWebCommand and SearchPage → SearchWebPage to align filenames and type names.
• Moved Icons.cs to Properties to consolidate assets.
• Renamed WebSearchShortcutItem → WebSearchShortcutDataEntry to better reflect the data role.
• Refactored SearchWebPage for easier readability.
• Renamed functions in WebSearchShortcutCommandsProvider for clearer intent.
• Refactored Suggestions for easier use and understanding.
• Reduced visibility where possible: changed public to internal/private.
• Replaced List<T> with T[] (internal immutable snapshots) or IReadOnlyList<T> (API boundaries) where mutation isn’t required.
• BrowserDiscovery: replaced double-checked locking with built-in Lazy<T> cache; reload now supports an optional warm mode.

Fixes

• Storage: WriteToFile now respects the caller-provided path.
• Standardized use of Icons.Search in OpenHomePageCommand and SearchWebCommand, removing hardcoded icons.
• BrowserDiscovery: Using built-in Lazy<T> fixes a potential memory-visibility issue where _isLoaded could be observed before _cachedBrowsers due to CPU/JIT reordering, ensuring readers never see stale/empty data after initialization.

Chore

• Removed outdated comments, code, and parameters; formatted the codebase.

[Testudinidae]

Consider renaming WebSearchShortcutItem to WebSearchShortcutEntry (or something else), since it’s not a UI element and is more like a data record.
Do you think this rename makes sense?

ps. Naming is hard 😅

[Daydreamer-riri]

Consider renaming WebSearchShortcutItem to WebSearchShortcutEntry (or something else), since it’s not a UI element and is more like a data record. Do you think this rename makes sense?

ps. Naming is hard 😅

That makes sense. Thanks!

[Testudinidae]

Ready... hopefully for real this time.

[Copilot]

Pull Request Overview

This refactoring PR improves code quality through better naming conventions, cleaner APIs, and enhanced maintainability. The changes focus on making the codebase more consistent and readable while maintaining all existing functionality.

• Renamed core classes and methods to better reflect their purpose (e.g., WebSearchShortcutItem → WebSearchShortcutDataEntry, SearchPage → SearchWebPage)
• Consolidated suggestion providers into a unified registry system with improved API design
• Enhanced browser discovery with thread-safe lazy initialization replacing manual double-checked locking

Reviewed Changes

Copilot reviewed 39 out of 40 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
WebSearchShortcutItem.cs	Removed old data model class
WebSearchShortcutDataEntry.cs	New data model with better naming and added GetHomePageUrl method
WebSearchShortcutCommandsProvider.cs	Refactored command provider with cleaner method names and improved organization
SuggestionsProviders/*.cs	Moved and updated suggestion providers with consistent interface implementation
Suggestion.cs	Refactored suggestions system into registry pattern with improved API
Storage.cs	Fixed path handling bug and updated to use new data model
SearchWebPage.cs	New search page implementation replacing SearchPage.cs
Commands/*.cs	Updated commands to use new data model and consistent icon usage
Properties/Icons.cs	Moved to Properties namespace and reordered for consistency

Files not reviewed (1)

• CmdPalWebSearchShortcut/WebSearchShortcut/Properties/Resources.Designer.cs: Language not supported

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[Daydreamer-riri]

Thank you very much for your contribution! Initially, this project was just a personal project, and many parts were not written meticulously (also, I'm just a beginner in dotnet, with my main development language being TypeScript), so there are many rough areas in the project code. This PR has addressed these issues! Thanks again for your contribution.