Use TVL with 'doublecounted' instead of Pool2 for Super DCA #16022
+7
−19
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Team,
I misunderstood how TVL would be displayed when I selected
pool2
. I looked over other adapters using Uniswap V4 Hooks and found thisdoublecounted
module export and I think this is more appropriate.This adapter does NOT count the Super DCA Token in the TVL. It only counts actual tokens (USDC, WBTC, ETH, AAVE). I hope by excluding the DCA token, it will be acceptable to classify this as Super DCA's TVL, with
doublecounted
indicating Super DCA's TVL resides inside of Uniswap V4.I hope you will consider accepting this update from
pool2
totvl
so that the Super DCA TVL is displayed on the chart. I have details about the Super DCA Liquidity Network construction here: https://github.com/Super-DCA-Tech/superdca-liquidity-network?tab=readme-ov-file#how-its-used. Super DCA creates a network of liquidity within the Uniswap V4 protocol.Thank you,
Mike
Please enable "Allow edits by maintainers" while putting up the PR.
package-lock.json
file as part of your changes, we use lockfileVersion 2, and most use v1 and using that messes up our CIName (to be shown on DefiLlama):
Super DCA
Twitter Link:
https://x.com/super_dca
List of audit links if any:
Website Link:
https://superdca.org
Logo (High resolution, will be shown with rounded borders):
Already shared.
Current TVL:
Treasury Addresses (if the protocol has treasury)
NA
Chain:
Base, Optimism
Coingecko ID (so your TVL can appear on Coingecko, leave empty if not listed): (https://api.coingecko.com/api/v3/coins/list)
NA
Coinmarketcap ID (so your TVL can appear on Coinmarketcap, leave empty if not listed): (https://api.coinmarketcap.com/data-api/v3/map/all?listing_status=active,inactive,untracked&start=1&limit=10000)
NA
Short Description (to be shown on DefiLlama):
Already shared.
Token address and ticker if any:
DCA
Category (full list at https://defillama.com/categories) *Please choose only one:
DCA Tools
Oracle Provider(s): Specify the oracle(s) used (e.g., Chainlink, Band, API3, TWAP, etc.):
Implementation Details: Briefly describe how the oracle is integrated into your project:
Documentation/Proof: Provide links to documentation or any other resources that verify the oracle's usage:
forkedFrom (Does your project originate from another project):
methodology (what is being counted as tvl, how is tvl being calculated):
Already shared.
Github org/user (Optional, if your code is open source, we can track activity):
Super-DCA-Tech