Skip to content

Use TVL with 'doublecounted' instead of Pool2 for Super DCA #16022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mikeghen
Copy link
Contributor

Hi Team,

I misunderstood how TVL would be displayed when I selected pool2. I looked over other adapters using Uniswap V4 Hooks and found this doublecounted module export and I think this is more appropriate.

This adapter does NOT count the Super DCA Token in the TVL. It only counts actual tokens (USDC, WBTC, ETH, AAVE). I hope by excluding the DCA token, it will be acceptable to classify this as Super DCA's TVL, with doublecounted indicating Super DCA's TVL resides inside of Uniswap V4.

I hope you will consider accepting this update from pool2 to tvl so that the Super DCA TVL is displayed on the chart. I have details about the Super DCA Liquidity Network construction here: https://github.com/Super-DCA-Tech/superdca-liquidity-network?tab=readme-ov-file#how-its-used. Super DCA creates a network of liquidity within the Uniswap V4 protocol.

Thank you,

Mike

Please enable "Allow edits by maintainers" while putting up the PR.


  • If you would like to add a volume/fees/revenue adapter please submit the PR here.
  • If you would like to add a liquidations adapter, please refer to this readme document for details.
  1. Once your adapter has been merged, it takes time to show on the UI. If more than 24 hours have passed, please let us know in Discord.
  2. Sorry, We no longer accept fetch adapter for new projects, we prefer the tvl to computed from blockchain data, if you have trouble with creating a the adapter, please hop onto our discord, we are happy to assist you.
  3. Please fill the form below only if the PR is for listing a new protocol else it can be ignored/replaced with reason/details about the PR
  4. For updating listing info It is a different repo, you can find your listing in this file: https://github.com/DefiLlama/defillama-server/blob/master/defi/src/protocols/data2.ts, you can edit it there and put up a PR
  5. Do not edit/push package-lock.json file as part of your changes, we use lockfileVersion 2, and most use v1 and using that messes up our CI
  6. No need to go to our discord and announce that you've created a PR, we monitor all PRs and will review it asap

Name (to be shown on DefiLlama):

Super DCA

Twitter Link:

https://x.com/super_dca

List of audit links if any:
Website Link:

https://superdca.org

Logo (High resolution, will be shown with rounded borders):

Already shared.

Current TVL:
------ TVL ------
optimism                  1.08 k
base                      1.05 k

total                    2.14 k 
Treasury Addresses (if the protocol has treasury)

NA

Chain:

Base, Optimism

Coingecko ID (so your TVL can appear on Coingecko, leave empty if not listed): (https://api.coingecko.com/api/v3/coins/list)

NA

Coinmarketcap ID (so your TVL can appear on Coinmarketcap, leave empty if not listed): (https://api.coinmarketcap.com/data-api/v3/map/all?listing_status=active,inactive,untracked&start=1&limit=10000)

NA

Short Description (to be shown on DefiLlama):

Already shared.

Token address and ticker if any:

DCA

Category (full list at https://defillama.com/categories) *Please choose only one:

DCA Tools

Oracle Provider(s): Specify the oracle(s) used (e.g., Chainlink, Band, API3, TWAP, etc.):
Implementation Details: Briefly describe how the oracle is integrated into your project:
Documentation/Proof: Provide links to documentation or any other resources that verify the oracle's usage:
forkedFrom (Does your project originate from another project):
methodology (what is being counted as tvl, how is tvl being calculated):

Already shared.

Github org/user (Optional, if your code is open source, we can track activity):

Super-DCA-Tech

@mikeghen
Copy link
Contributor Author

This test failure looks unrelated to this change. Let me know if there's something I need to do to resolve this CI check failure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant