Allow enum datatypes to be set to their enum values #174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olliesilvester
commented
Aug 4, 2025
| @@ -1,5 +1,5 @@ | |||
| [build-system] | |||
| requires = ["setuptools>=64", "setuptools_scm[toml]>=8"] | |||
| requires = ["setuptools>=70.1", "setuptools_scm[toml]>=8"] | |||
There was a problem hiding this comment.
This version was required for pytest to work in a devcontainer
There was a problem hiding this comment.
Yep I have seen this issue recently. For reference, this is the error
$ pytest
ImportError while loading conftest '/workspaces/FastCS/tests/conftest.py'.
tests/conftest.py:17: in <module>
from aioca import purge_channel_caches
/venv/lib/python3.11/site-packages/aioca/__init__.py:1: in <module>
from epicscorelibs.ca.cadef import DBE_ALARM, DBE_LOG, DBE_PROPERTY, DBE_VALUE
/venv/lib/python3.11/site-packages/epicscorelibs/ca/cadef.py:22: in <module>
from epicscorelibs import path
/venv/lib/python3.11/site-packages/epicscorelibs/path/__init__.py:4: in <module>
from setuptools_dso.runtime import dylink_prepare_dso, find_dso
/venv/lib/python3.11/site-packages/setuptools_dso/__init__.py:10: in <module>
from .dsocmd import DSO, Extension, install, build, build_dso, build_ext, bdist_egg
/venv/lib/python3.11/site-packages/setuptools_dso/dsocmd.py:26: in <module>
_bdist_wheel = _import_bdist_wheel()
^^^^^^^^^^^^^^^^^^^^^
/venv/lib/python3.11/site-packages/setuptools_dso/dsocmd.py:21: in _import_bdist_wheel
from wheel.bdist_wheel import bdist_wheel
/venv/lib/python3.11/site-packages/wheel/bdist_wheel.py:4: in <module>
warn(
E DeprecationWarning: The 'wheel' package is no longer the canonical location of the 'bdist_wheel' command, and will be removed in a future release. Please update to setuptools v70.1 or later which contains an integrated version of this command.
Could you split the pyproject change into a separate commit?
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #174 +/- ##
==========================================
+ Coverage 92.28% 92.30% +0.01%
==========================================
Files 40 40
Lines 2009 2014 +5
==========================================
+ Hits 1854 1859 +5
Misses 155 155 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Discussed with @GDYendell : We think that solving #159 should fix #137 , so this PR may not be required. I will draft this PR for now, and then close it if we can fix it in that other way |
jsouter
reviewed
Aug 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #173