Skip to content

Add generic interactive shell #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Aug 14, 2025
Merged

Add generic interactive shell #189

merged 16 commits into from
Aug 14, 2025

Conversation

shihab-dls
Copy link
Contributor

@shihab-dls shihab-dls commented Aug 12, 2025

fixes #140

This PR adds an interactive shell, based on this implementation, and adds transport contexts. The wip commits are attempts to add dbl dbpf and dbgf functionality to PVA as an example, but maybe only the first commit is required for this PR, and further PRs can add transport specific context.

@shihab-dls
Copy link
Contributor Author

I will request an initial review to decide on steps forward (i.e., reverting wip commits and keeping generic, or continuing on transport context).

The failed test is due to asserting a specific message is printing out, where the terminal is now injecting it's messages (e.g., 'In [1]:). Should we disable the terminal with some test ENV VAR instead of working around it in these sorts of tests?

@shihab-dls shihab-dls requested a review from GDYendell August 12, 2025 15:25
@shihab-dls
Copy link
Contributor Author

I've removed implementations of transport context for pva; instead I made this #190 for CA. This PR is now only the generic implementation.

Copy link
Contributor

@GDYendell GDYendell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small comments

Copy link

codecov bot commented Aug 14, 2025

Codecov Report

❌ Patch coverage is 89.28571% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.20%. Comparing base (64a7828) to head (e72f1f5).

Files with missing lines Patch % Lines
src/fastcs/launch.py 88.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #189      +/-   ##
==========================================
- Coverage   92.25%   92.20%   -0.06%     
==========================================
  Files          40       40              
  Lines        2040     2065      +25     
==========================================
+ Hits         1882     1904      +22     
- Misses        158      161       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@shihab-dls
Copy link
Contributor Author

shihab-dls commented Aug 14, 2025

I've commented out fastcs.run() lines that were in some doc snippets for now, and removed the env var. Re-requesting a review with the generic terminal and the amended test. I've also added a test for the duplicate context error for coverage; let me know if you would've tested it another way.

@shihab-dls shihab-dls requested a review from GDYendell August 14, 2025 12:01
@GDYendell
Copy link
Contributor

I think I am OK with leaving that run method with missing lines unless you can come up with a neat way to test that

@shihab-dls
Copy link
Contributor Author

I think I am OK with leaving that run method with missing lines unless you can come up with a neat way to test that

Hit my head against it for a little while, and can't figure out a "neat" way to do it; I can open up a small issue for me to look at after, but for now we should probably merge this in (if you are happy with my other test)?

@GDYendell GDYendell merged commit 5231029 into main Aug 14, 2025
16 of 18 checks passed
@GDYendell GDYendell deleted the 140_interactive_shell branch August 14, 2025 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a generic interactive shell and allow transports to add to the context
2 participants