-
Notifications
You must be signed in to change notification settings - Fork 370
Merging Private Branch contents from Kevin's Repo. #888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
like 'ESAPI.enableLegCannonModeAndGetMyAssFired.justification' better. ;-)
…led if someone wants to use it.
Updating parameter null check to test null case. Removing null check on property result (if null ConfigurationException is thrown). Simplifying return from method to verify response is not empty.
Adding branch testing for ESAPI.isMethodExplicitlyEnabled behavior to account for parameter cases. Only case not covered is providing an ESAPI.properties that does not contain the new key.
using the SecurityConfigurationWrapper to verify remaining test case when a ConfigurationException is thrown when the new property is missing or undefined.
Initial code to disable encodeForSQL
… is, despite best intentions.
Plus minor type fix ('class' ==> 'method').
…idn't affect HTTPUtilities.getFileUploads interaces anyway.
…to include its summary description.)
kwwall
approved these changes
Jun 27, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I may be biased, but LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.