-
Notifications
You must be signed in to change notification settings - Fork 42
Make cubes with different coordinate systems work with extract_location #2186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…has coordinates with an associated coordinate system
Codecov Report
@@ Coverage Diff @@
## main #2186 +/- ##
==========================================
- Coverage 93.10% 93.01% -0.10%
==========================================
Files 237 237
Lines 12826 12845 +19
==========================================
+ Hits 11942 11948 +6
- Misses 884 897 +13
|
In order to maintain a backlog of relevant pull requests, we automatically label them as stale after 180 days of inactivity. If this pull request is still important to you, please comment below to remove the stale label. Otherwise, this pull request will be automatically closed in 60 days. If this pull request only suffers from a lack of reviewers, please tag the @ESMValGroup/technical-lead-development-team so they can help you find a suitable reviewer. |
shut up, bot! I reckon we should revisit this one soon |
Description
When using CORDEX data on a model with a rotated pole grid with the extract_location pre-processor it fails with:
ValueError: Interpolation coords must be 1-d for rectilinear interpolation.
This branch extends the function: extract_point in preprocessor/_regrid.py
to cope with cases where the dimension coordinates are not latitude and longitude
Closes #2177
TO DO:
tests/unit/preprocessor/_regrid/test_extract_point.py
#2193Link to documentation:
Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
To help with the number pull requests: