Skip to content

Conversation

larsbuntemeyer
Copy link

@larsbuntemeyer larsbuntemeyer commented Oct 6, 2023

Description

closes #2221

Link to documentation:


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.27%. Comparing base (469fd09) to head (3aae9ff).
⚠️ Report is 401 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2220   +/-   ##
=======================================
  Coverage   93.27%   93.27%           
=======================================
  Files         238      238           
  Lines       12818    12818           
=======================================
  Hits        11956    11956           
  Misses        862      862           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bouweandela
Copy link
Member

To get these CORDEX related projects to work with the complete tool (i.e. use them in recipes), not just the esmvalcore.esgf module used for finding files and downloading them, you will probably want to add entries to the file esmvalcore/config-developer.yml, similar to the current CORDEX entry:

CORDEX:
input_dir:
default: '/'
spec: '{domain}/{institute}/{driver}/{exp}/{ensemble}/{institute}-{dataset}/{rcm_version}/{mip}/{short_name}'
BADC: '{domain}/{institute}/{driver}/{exp}/{ensemble}/{institute}-{dataset}/{rcm_version}/{mip}/{short_name}/{version}'
DKRZ: '{domain}/{institute}/{driver}/{exp}/{ensemble}/{institute}-{dataset}/{rcm_version}/{mip}/{short_name}/{version}'
ESGF: '{project.lower}/output/{domain}/{institute}/{driver}/{exp}/{ensemble}/{dataset}/{rcm_version}/{frequency}/{short_name}/{version}'
SYNDA: '{domain}/{institute}/{driver}/{exp}/{ensemble}/{dataset}/{rcm_version}/{frequency}/{short_name}/{version}'
input_file: '{short_name}_{domain}_{driver}_{exp}_{ensemble}_{institute}-{dataset}_{rcm_version}_{mip}*.nc'
output_file: '{project}_{institute}_{dataset}_{rcm_version}_{driver}_{domain}_{mip}_{exp}_{ensemble}_{short_name}'
cmor_type: 'CMIP5'
cmor_path: 'cordex'

@larsbuntemeyer
Copy link
Author

@bouweandela thanks for that! Sorry, i have been a bit lazy on this one, i'll still have to finish testing...

Copy link
Contributor

In order to maintain a backlog of relevant pull requests, we automatically label them as stale after 180 days of inactivity.

If this pull request is still important to you, please comment below to remove the stale label. Otherwise, this pull request will be automatically closed in 60 days. If this pull request only suffers from a lack of reviewers, please tag the @ESMValGroup/technical-lead-development-team so they can help you find a suitable reviewer.

@github-actions github-actions bot added the Stale label Jun 27, 2025
Copy link
Contributor

This stale pull request has been automatically closed due to a lack of community activity.

If you still care about this pull request, please re-open it. If you do not have sufficient permissions for this, tag the @ESMValGroup/technical-lead-development-team in a comment below including a short message that this pull request is still relevant to you. They will re-open it on your behalf.

@github-actions github-actions bot closed this Aug 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ESGF facets for CORDEX-Adjust, CORDEX-ESD, CORDEX-Reklies
2 participants