Skip to content

Conversation

morobking
Copy link

@morobking morobking commented Jun 18, 2024

This pull request is part of the CMUG work package on uncertainty propagation in ESMValTool with @morobking and @axel-lauer. It is part of issue ESMValGroup/ESMValTool#3408.
A separate pull request exists in ESMValTool for branch cmorise_cci_lst_v3.
This pull request has the new CMOR tables needed to CMORise the CCI LST V3 data with the above.

Description

Closes #issue_number

Link to documentation:


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

@valeriupredoi
Copy link
Contributor

cheers @morobking - if you could please clean up the PR description ie check boxes that need checking, and strikethrough or delete those that don't that be awesome 🍺

@valeriupredoi valeriupredoi added the cmor Related to the CMOR standard label Aug 6, 2024
Copy link

codecov bot commented Aug 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.71%. Comparing base (9636505) to head (01974b6).
Report is 190 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2458   +/-   ##
=======================================
  Coverage   94.71%   94.71%           
=======================================
  Files         249      249           
  Lines       14123    14123           
=======================================
  Hits        13376    13376           
  Misses        747      747           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@morobking
Copy link
Author

@valeriupredoi I've updated the list.
Where and what documentation is needed for the new CMOR tables?
Backwards compatible - not sure how to test this or if it is relevant for just new tables?

Copy link
Contributor

In order to maintain a backlog of relevant pull requests, we automatically label them as stale after 180 days of inactivity.

If this pull request is still important to you, please comment below to remove the stale label. Otherwise, this pull request will be automatically closed in 60 days. If this pull request only suffers from a lack of reviewers, please tag the @ESMValGroup/technical-lead-development-team so they can help you find a suitable reviewer.

@github-actions github-actions bot added the Stale label Jun 27, 2025
@morobking
Copy link
Author

This is not stale - paused this while myself, @axel-lauer and Claire Bulgin reviewed the maths/science in the related PRs and code.

@github-actions github-actions bot removed the Stale label Jun 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmor Related to the CMOR standard
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

2 participants