-
Notifications
You must be signed in to change notification settings - Fork 42
Expand Dataset.from_files
so it works properly with derived variables
#2777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…es_with_derived_vars
Co-authored-by: Bouwe Andela <b.andela@esciencecenter.nl>
Co-authored-by: Bouwe Andela <b.andela@esciencecenter.nl>
…es_with_derived_vars
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2777 +/- ##
==========================================
+ Coverage 95.41% 95.42% +0.01%
==========================================
Files 260 260
Lines 15409 15421 +12
==========================================
+ Hits 14703 14716 +13
+ Misses 706 705 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
another superb PR, Manu 🍻 - I really got nothing to raise here, but I'd defer a quick looksee to @bouweandela too, just one minor comment related to one test from me 🍻
@LisaBock This is the PR I talked about earlier. This is necessary to be able to properly use the |
Would this be ready to be merged @LisaBock ? Or another review from @bouweandela ? |
I would be happy to do a review, but will need some time as this is 1300 lines of new/changed code |
Description
This PR expands
Dataset.from_files
so it works properly with derived variables. In addition, a new attributeDataset.input_datasets
is available which returns the datasets necessary for derivation (or simply the dataset itself is no derivation is required). This can also be used within thederive
preprocessor function.This PR is the second step to make
Dataset.load
work with derived variables.Example
Related to #2769.
Link to documentation:
Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
To help with the number pull requests: