Narc shares guess access with Crewmates instead of Impostors #1572

impostor4291 · 2025-05-11T06:04:18Z

No description provided.

MargaretTheFool · 2025-05-15T19:44:01Z

Modules/GuessManager.cs

@@ -119,17 +119,17 @@ public static bool GuesserMsg(PlayerControl pc, string msg, bool isUI = false)
            pc.ShowInfoMessage(isUI, GetString("GuessDead"));
            return true;
        }
-        if (!pc.Is(CustomRoles.NiceGuesser))
+        if (!pc.Is(CustomRoles.NiceGuesser) && !(pc.Is(CustomRoles.EvilGuesser) && pc.Is(CustomRoles.Narc)))


if someone is evil guessser and not narc (which would also make them not be nice guesser), this would trigger because
!(F) && !(T && F)
T && !(F)
T && T
T

MargaretTheFool · 2025-05-15T19:44:49Z

Modules/GuessManager.cs

@@ -243,7 +243,7 @@ public static bool GuesserMsg(PlayerControl pc, string msg, bool isUI = false)

                if (!role.IsEnable() && !role.RoleExist(true) && Options.CanOnlyGuessEnabled.GetBool())
                {
-                    pc.ShowInfoMessage(isUI, string.Format(GetString("GuessRoleNotEnabled"), role.ToString()));
+                    pc.ShowInfoMessage(isUI, string.Format(GetString("GuessRoleNotEnabled"), GetString(role.ToString())));


why is this needed?

impostor4291 · 2025-05-16T13:16:15Z

Modules/GuessManager.cs

        {
-            if (pc.GetCustomRole().IsCrewmate() && !Options.CrewmatesCanGuess.GetBool() && !pc.Is(CustomRoles.Guesser) && !pc.Is(CustomRoles.Judge))
+            if ((pc.Is(Custom_Team.Crewmate) || pc.Is(CustomRoles.Narc)) && !Options.CrewmatesCanGuess.GetBool() && !pc.Is(CustomRoles.Guesser) && !pc.Is(CustomRoles.Judge))


but this wont be triggered by non-narc evil guesser
nvm narc councillor will trigger this

Copilot

Pull Request Overview

Adds support for the Narc role sharing Crewmate guessing permissions instead of Impostors.

Introduces a new NarcEGCanGuessCrew option and updates UI hiding logic in EvilGuesser.
Extends GuessManager checks to include Narc in Crewmate/Impostor guess permission branches.
Adds a localization entry for the new option.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File	Description
Roles/Impostor/EvilGuesser.cs	Adds `NarcEGCanGuessCrew` option and updates tab/UI logic for Narc.
Resources/Lang/en_US.json	Adds localization string for `NarcEGCanGuessCrew`.
Modules/GuessManager.cs	Updates guess permission checks and meeting UI button logic to handle Narc.

Comments suppressed due to low confidence (1)

Modules/GuessManager.cs:652

This condition is unreachable because a player cannot simultaneously have the EvilGuesser and Narc roles. You’ll need to adjust the logic to target the intended role combination.

else if ((PlayerControl.LocalPlayer.GetCustomRole() is CustomRoles.EvilGuesser && PlayerControl.LocalPlayer.Is(CustomRoles.Narc)) && !Options.CrewmatesCanGuess.GetBool())

Copilot · 2025-05-25T15:25:11Z

Resources/Lang/en_US.json

@@ -1577,6 +1577,7 @@
  "NarcHasCrewVision": "Narc Has <color=#8cffff>Crewmate</color> Vision",
  "MadmateCanBeNarc": "<color=#ff1919>Madmate</color> Roles Can Be Narc",
  "ImpsCanKillEachOther": "<color=#ff1919>Impostors</color> Can Kill Each Other",
+  "NarcEGCanGuessCrew": "<color=#1e90ff>Narc</color> Evil Guesser Can Guess <color=#8cffff>Crewmate</color> Roles</color>",


There is an extra closing tag at the end of this string. Remove the unmatched .

Suggested change

"NarcEGCanGuessCrew": "<color=#1e90ff>Narc</color> Evil Guesser Can Guess <color=#8cffff>Crewmate</color> Roles</color>",

"NarcEGCanGuessCrew": "<color=#1e90ff>Narc</color> Evil Guesser Can Guess <color=#8cffff>Crewmate</color> Roles",

Copilot · 2025-05-25T15:25:11Z

Modules/GuessManager.cs

-        {
-            if (pc.GetCustomRole().IsCrewmate() && !Options.CrewmatesCanGuess.GetBool() && !pc.Is(CustomRoles.Guesser) && !pc.Is(CustomRoles.Judge))
+        if ((pc.Is(Custom_Team.Crewmate) || pc.Is(CustomRoles.Narc)) && !Options.CrewmatesCanGuess.GetBool())
+        { // Don't ask me why this also checks Evil Guesser and Councillor. They can be Narc


[nitpick] This informal comment is unclear and doesn’t explain the rationale. Consider removing it or replacing it with a concise explanation of why those roles need to be included.

Suggested change

{ // Don't ask me why this also checks Evil Guesser and Councillor. They can be Narc

{ // The roles "Evil Guesser" and "Councillor" are checked here because they can also be associated with the "Narc" role in certain game scenarios.

bro even reads notes :omgcry:

NikoCat233

Maybe add a option to choose to share guesses with imp or crews

impostor4291 added 10 commits May 11, 2025 12:23

evil guesser part

3e1c6f8

forgot to block guesses

ae40499

guess manager

80c60da

Update GuessManager.cs

eec15f8

Update EvilGuesser.cs

7dc8c0f

Update EvilGuesser.cs

75d29d5

Update EvilGuesser.cs

57dc952

one extra G...

f2c93d7

Update EvilGuesser.cs

365b2df

Update GuessManager.cs

0e97080

MargaretTheFool added the Some change Added when small changes are made label May 13, 2025

MargaretTheFool added this to TOHE 2.3.0 Development May 13, 2025

MargaretTheFool moved this to Roles in TOHE 2.3.0 Development May 13, 2025

MargaretTheFool reviewed May 15, 2025

View reviewed changes

add councillor

62184c8

impostor4291 commented May 16, 2025

View reviewed changes

impostor4291 added 2 commits May 18, 2025 12:43

Update GuessManager.cs

23a91a8

um...idk how to name this

a001a8a

NikoCat233 requested a review from Copilot May 25, 2025 15:23

Copilot AI reviewed May 25, 2025

View reviewed changes

impostor4291 added 4 commits May 25, 2025 23:38

remove

ef8481a

bro even reads notes :omgcry:

Update en_US.json

57f68cc

merge

22c6aeb

merge

a8fd576

NikoCat233 requested changes Jun 15, 2025

View reviewed changes

impostor4291 added 3 commits June 30, 2025 08:19

merge

9800911

Update Narc.cs

a3b4947

Update en_US.json

dd07372

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Narc shares guess access with Crewmates instead of Impostors #1572

Narc shares guess access with Crewmates instead of Impostors #1572

Uh oh!

impostor4291 commented May 11, 2025

Uh oh!

MargaretTheFool May 15, 2025

Uh oh!

impostor4291 May 16, 2025

Uh oh!

MargaretTheFool May 15, 2025

Uh oh!

impostor4291 May 16, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI May 25, 2025

Uh oh!

Copilot AI May 25, 2025

Uh oh!

NikoCat233 left a comment •

edited

Loading

Uh oh!

Uh oh!

	"NarcEGCanGuessCrew": "<color=#1e90ff>Narc</color> Evil Guesser Can Guess <color=#8cffff>Crewmate</color> Roles</color>",
	"NarcEGCanGuessCrew": "<color=#1e90ff>Narc</color> Evil Guesser Can Guess <color=#8cffff>Crewmate</color> Roles",

	{ // Don't ask me why this also checks Evil Guesser and Councillor. They can be Narc
	{ // The roles "Evil Guesser" and "Councillor" are checked here because they can also be associated with the "Narc" role in certain game scenarios.

Uh oh!

Narc shares guess access with Crewmates instead of Impostors #1572

Are you sure you want to change the base?

Narc shares guess access with Crewmates instead of Impostors #1572

Uh oh!

Conversation

impostor4291 commented May 11, 2025

Uh oh!

MargaretTheFool May 15, 2025

Choose a reason for hiding this comment

Uh oh!

impostor4291 May 16, 2025

Choose a reason for hiding this comment

Uh oh!

MargaretTheFool May 15, 2025

Choose a reason for hiding this comment

Uh oh!

impostor4291 May 16, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI May 25, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI May 25, 2025

Choose a reason for hiding this comment

Uh oh!

NikoCat233 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

NikoCat233 left a comment •

edited

Loading