-
Notifications
You must be signed in to change notification settings - Fork 95
feat: Add and remove influence #330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
You can add these two together as well /// <summary>
/// Get influence to a given <see cref="Faction"/>.
/// </summary>
/// <param name="faction">The <see cref="Faction"/> to get influence.</param>
/// <returns>Get the faction influence..</returns>
public static float GetInfluence(Faction faction)
{
return FactionInfluenceManager.Get(faction);
}
/// <summary>
/// Set influence to a given <see cref="Faction"/>.
/// </summary>
/// <param name="faction">The <see cref="Faction"/> to set influence.</param>
/// <param name="influence">The amount of influence to set.</param>
public static void SetInfluence(Faction faction, float influence)
{
FactionInfluenceManager.Set(faction, influence);
} |
Done. 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everytring can be inlined
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
like asked by valera: use inlining
Y e s |
Everyting is good but PR must target dev branch |
Description
Describe the changes
It seemed pretty weird to me that those functions weren't here in the first place.
What is the current behavior? (You can also link to an open issue here)
What is the new behavior? (if this is a feature change)
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No.
Other information:
Types of changes
Submission checklist
Patches (if there are any changes related to Harmony patches)
Other