fix: SetFakeScale doesnt execute with currentScale #349
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* ci: add a new workflow to validate pr title * refactor: edit `pull_request_opened` workflow to add "valide PR title" check * refactor: remove previous workflow for pr title * refactor: a small change on the name of each job
AlexInABox
changed the title
louis1706
approved these changes
Dec 27, 2024
|
You should target dev btw |
I switched the base for the pr. Does this work or should open a new one? EDIT: yeah nvm im opening a new pr, targeting dev mb !! |
AlexInABox
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://discord.com/channels/656673194693885975/1002713309876854924/1317978520701501482
Description
Describe the changes
The Player.SetFakeScale method now no longer checks if the proposed fakeScale is the current real scale of the player.
What is the current behavior? (You can also link to an open issue here)
The current behaviour does not allow for the fakeScale to be reset e.g.
What is the new behavior? (if this is a feature change)
The current behaviour does allow for the fakeScale to be reset
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Other information:
Types of changes
Submission checklist
Patches (if there are any changes related to Harmony patches)
Other
I can and will not compile this. If this looks alright, please some reviewer test it thx! :3