Skip to content

fix: Fixing merged pr 189 & #342 & #355 #359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Dec 31, 2024

Conversation

louis1706
Copy link

Description

Describe the changes

What is the current behavior? (You can also link to an open issue here)

What is the new behavior? (if this is a feature change)

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

Other information:


Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentations

Submission checklist

  • I have checked the project can be compiled
  • I have tested my changes and it worked as expected

Patches (if there are any changes related to Harmony patches)

  • I have checked no IL patching errors in the console

Other

  • Still requires more testing

@louis1706 louis1706 added the Do not merge Don't merge this PR label Dec 31, 2024
@louis1706 louis1706 changed the base branch from master to dev December 31, 2024 01:56
@github-actions github-actions bot added Transpiler API base-game-bug Bug from the main game labels Dec 31, 2024
@louis1706 louis1706 changed the title Fixing merged pr 189 & #342 & #355 (not finish) Fixing merged pr 189 & #342 & #355 Dec 31, 2024
@louis1706 louis1706 marked this pull request as ready for review December 31, 2024 13:22
@louis1706 louis1706 changed the title Fixing merged pr 189 & #342 & #355 fix: Fixing merged pr 189 & #342 & #355 Dec 31, 2024
@louis1706 louis1706 added bug Something isn't working and removed base-game-bug Bug from the main game Do not merge Don't merge this PR labels Dec 31, 2024
@VALERA771 VALERA771 requested a review from Misfiy December 31, 2024 15:54
@github-actions github-actions bot added the base-game-bug Bug from the main game label Dec 31, 2024
@louis1706 louis1706 removed the base-game-bug Bug from the main game label Dec 31, 2024
@louis1706 louis1706 merged commit d7425db into ExMod-Team:dev Dec 31, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API bug Something isn't working Transpiler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants