fix: Add Player to TrackedPlayers before setting role #606
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes
I changed ordering of when player officially "receives" custom role so using Check() in OnSpawned / OnChangingRole will actually work, I had to make a workaround to avoid the InternalChangingRole event from removing the custom role instantly, but it should work.
What is the current behavior? (You can also link to an open issue here)
Check() in a CR doesn't work in OnSpawned when they receive a role
What is the new behavior? (if this is a feature change)
Check() will work in OnSpawned and OnChangingRole
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Other information:
Yamato said he'd test this so it might not work as I haven't tested it
Types of changes
Submission checklist
Patches (if there are any changes related to Harmony patches)
Other