Skip to content

fix: Add Player to TrackedPlayers before setting role #606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 6, 2025

Conversation

Someone-193
Copy link

Description

Describe the changes
I changed ordering of when player officially "receives" custom role so using Check() in OnSpawned / OnChangingRole will actually work, I had to make a workaround to avoid the InternalChangingRole event from removing the custom role instantly, but it should work.

What is the current behavior? (You can also link to an open issue here)
Check() in a CR doesn't work in OnSpawned when they receive a role

What is the new behavior? (if this is a feature change)
Check() will work in OnSpawned and OnChangingRole

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

Other information:
Yamato said he'd test this so it might not work as I haven't tested it

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentations

Submission checklist

  • I have checked the project can be compiled
  • I have tested my changes and it worked as expected

Patches (if there are any changes related to Harmony patches)

  • I have checked no IL patching errors in the console

Other

  • Still requires more testing

@louis1706 louis1706 merged commit 0fde095 into ExMod-Team:dev Aug 6, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants