fix: firearms spawning with max ammo after being dropped #607
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
now only newly created firearm pickups have max ammo in mag (rather than all 😭 )
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes
Fixes bug
What is the current behavior? (You can also link to an open issue here)
All dropped guns spawn with max ammo, regardless of how much they should have
What is the new behavior? (if this is a feature change)
Only newly spawned guns spawned directly from Pickup.Create get max ammo
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Other information:
I have made a severe and continuous lapse in my judgement (I made PR that caused the bug)
Types of changes
Submission checklist
Patches (if there are any changes related to Harmony patches)
Other