Add enums required for GObject >=3.51.0 #105
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Indeed that's the right way of fixing this issue, however, this is more of a PyGObject issue with the binding, PyGObject should automatically detect what is an enum and what's not... I had multiple plans of fixing this issue however I took the easiest route and that is waiting till upstream is fixed. I also thought about editing the implementation of |
|
Are they aware of the issue? I looked at issues on gnome's gitlab for gobject-introspection but can't tell if any of them relate to this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if that's the best approach or if it maybe should be implemented somewhere else.
Took the enums from gtk-layer-shell.
It works and in the worst case I hope this saves the maintainers some time diagnosing the cause
ref: https://gitlab.gnome.org/GNOME/pygobject/-/blob/main/docs/guide/api/flags_enums.rst