Skip to content

refactor: README theme generation logic #485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 26, 2024
Merged

Conversation

Viole07
Copy link
Contributor

@Viole07 Viole07 commented Oct 26, 2024

Description

Refactor the README theme generation logic for improved readability and reduced redundancy.

Fixes none

Type of change

  • Bug fix (added a non-breaking change which fixes an issue)
  • New feature (added a non-breaking change which adds functionality)
  • Updated documentation (updated the readme, templates, or other repo files)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Misc change (updated other files non-breaking change)

How Has This Been Tested?

  • Tested locally with a valid username
  • Tested locally with an invalid username
  • Ran tests with npm test
  • Added or updated test cases to test new features

Checklist:

  • I have checked to make sure no other pull requests are open for this issue
  • The code is properly formatted and is consistent with the existing code style
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Screenshots

none

Copy link

vercel bot commented Oct 26, 2024

@Viole07 is attempting to deploy a commit to the fajarkim's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added the ci label Oct 26, 2024
@FajarKim FajarKim self-requested a review October 26, 2024 06:36
@FajarKim
Copy link
Owner

Great job. Thanks for your contribution 🎉

@FajarKim FajarKim merged commit 7c1730e into FajarKim:master Oct 26, 2024
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants