Update pom.xml to 0.5.0 #134
Conversation
|
Caution Review failedThe pull request is closed. WalkthroughThe Maven project version in the Changes
Possibly related PRs
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #134 +/- ##
=========================================
Coverage 75.00% 75.00%
Complexity 223 223
=========================================
Files 25 25
Lines 688 688
Branches 64 64
=========================================
Hits 516 516
Misses 136 136
Partials 36 36 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (2)
.github/workflows/snapshot.yml (2)
5-7: Consider using wildcard for branch patterns.
Listing a single branch name (gkorland-patch-1) may require manual updates for each new patch branch. Use a wildcard pattern (e.g.,gkorland-patch-*) to automatically include future patch branches.
36-36: Remove trailing spaces.
Line 36 has trailing whitespace which will be flagged byyamllint. Please remove the extra spaces aftergo-offline.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
.github/workflows/snapshot.yml(1 hunks)pom.xml(4 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- pom.xml
🧰 Additional context used
🪛 YAMLlint (1.37.1)
.github/workflows/snapshot.yml
[error] 36-36: trailing spaces
(trailing-spaces)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Analyze (java)
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
pom.xml(3 hunks)
🧰 Additional context used
🪛 GitHub Actions: Publish Snapshot
pom.xml
[error] 1-1: Failed to execute goal org.sonatype.central:central-publishing-maven-plugin:0.8.0:publish: Could not transfer metadata com.falkordb:jfalkordb:0.5.0-SNAPSHOT/maven-metadata.xml from/to central repository due to 'No address associated with hostname' for central.sonatype.dev.
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: Analyze (java)
- GitHub Check: build
🔇 Additional comments (12)
pom.xml (12)
4-4: Relocate modelVersion correctly.
Moving<modelVersion>to the top aligns with Maven POM conventions and has no functional impact.
14-15: Bump project version and adjust packaging.
Updating to0.5.0-SNAPSHOTand explicitly declaring<packaging>jar</packaging>is correct for the upcoming snapshot release.
18-18: Standardize project description.
Capitalizing "Official client for FalkorDB" improves metadata consistency.
22-23: Fix organization metadata.
Correcting the organization name to "FalkorDB" and using HTTPS for its URL is appropriate.
32-32: Capitalize issue management system.
Changing<system>toGitHubmatches official naming.
44-44: Correct license identifier.
Updating the license name toBSD 3-Clausefixes the SPDX identifier.
50-56: Reformat developers section.
The developer block is reformatted without content changes; this is a layout improvement.
70-73: Simplify compiler properties.
Retaining only the necessary<maven.compiler.source>and<maven.compiler.target>properties cleans up unused settings.
99-102: Downgrade EqualsVerifier for Java 8 compatibility.
Pinningequalsverifierto 3.14.2 ensures compatibility with the Java 8 toolchain.Please verify that this version covers all required equality tests in our codebase, especially if any classes rely on newer features.
108-112: Promote Surefire plugin.
Moving the Maven Surefire Plugin to the top of the build plugins list emphasizes its role in test execution.
134-146: Integrate Source plugin.
Adding the Maven Source Plugin execution in the main build ensures source jars are attached without forking the lifecycle.
148-160: Integrate Javadoc plugin.
Including the Maven Javadoc Plugin for javadoc jar attachment in the main build is correct.
Summary by CodeRabbit