-
-
Notifications
You must be signed in to change notification settings - Fork 542
Reimplementation of logarithmic volume #1744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
Oops, I accidentally messed up App.xaml.cs, gonna revert it |
By the way, I think the Chinese translation of the switch should be “使用对数比例音量条” or “用对数比例表示音量” rather than “使用对数音量缩放” The min dB setting may be called “对数比例音量条的最低分贝” |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty great(!), just some minor things. I'll test it out and have some feedback on text for loc.
EarTrumpet/DataModel/WindowsAudio/Internal/AudioDeviceSession.cs
Outdated
Show resolved
Hide resolved
Thanks for your appreciation! I didn't test it out thoroughly though and there might still be some intermittent bugs. |
Width="200" | ||
IsSnapToTickEnabled="True" | ||
TickFrequency="1" | ||
IsDirectionReversed="True" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking of this slider as the volume range so I made it reversed but… the color is also reversed. I'm considering whether to un-reverse it or just change the label to range instead of min dB. How do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your choice, but the color needs to be flipped so it matches everyone's expectations of that slider control.
Related issue #1703
All features mentioned in that issue are implemented.
Added
Changed
Notes
Channels don't automatically get muted when slider is at the minimum, this is by design, not a bug, since it's still a non-zero value.Known Problems
Added UseLogarithmicVolumeChanged event handlers to various classes, but this may cause memory leak in AudioDeviceSession because that class don't have any clean up mechanism. (Finalizers won't work)