Skip to content

Do not delete system trace session with missing parent process (fix for https://github.com/FirebirdSQL/firebird/issues/8180) #8179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 10, 2024
Merged

Do not delete system trace session with missing parent process (fix for https://github.com/FirebirdSQL/firebird/issues/8180) #8179

merged 2 commits into from
Jul 10, 2024

Conversation

Noremos
Copy link
Contributor

@Noremos Noremos commented Jul 10, 2024

No description provided.

@Noremos
Copy link
Contributor Author

Noremos commented Jul 10, 2024

Sometimes a system session can just disappear. The easiest way to reproduce the problem is to run 2 tests via firebird-qa:
python3 -m pytest --server local --disable-db-cache tests/bugs/core_2940_test.py tests/bugs/core_2981_test.py
The second test will fail with the following result:
Trace session ID 3 not found

@dyemanov dyemanov changed the title Do not delete system session with missing parent process Do not delete system trace session with missing parent process Jul 10, 2024
hvlad
hvlad requested changes Jul 10, 2024
View reviewed changes
Copy link
Member

@hvlad hvlad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not clear what problem this PR going to solve.
Why there is no corresponding issue ?

@Noremos Noremos changed the title Do not delete system trace session with missing parent process Do not delete system trace session with missing parent process (fix for #8180) Jul 10, 2024
@Noremos
Copy link
Contributor Author

Noremos commented Jul 10, 2024

It is not clear what problem this PR going to solve. Why there is no corresponding issue ?

Sorry, here is the issue: #8180

@Noremos Noremos changed the title Do not delete system trace session with missing parent process (fix for #8180) Do not delete system trace session with missing parent process (fix for https://github.com/FirebirdSQL/firebird/issues/8180) Jul 10, 2024
@hvlad
Copy link
Member

hvlad commented Jul 10, 2024

It is not clear what problem this PR going to solve. Why there is no corresponding issue ?

Sorry, here is the issue: #8180

Thanks

@dyemanov dyemanov linked an issue Jul 10, 2024 that may be closed by this pull request
Sometimes a trace session is terminated spontaneously #8180
Closed
@dyemanov dyemanov merged commit b83d736 into FirebirdSQL:v5.0-release Jul 10, 2024
24 checks passed
dyemanov pushed a commit that referenced this pull request Jul 10, 2024
@Noremos @dyemanov
Do not delete system trace session with missing parent process (fix for
cd0eea5 
#8180) (#8179)

* Do not compact system session with missing parent process

* Replace assert with fb_assert

---------

Co-authored-by: Artyom Abakumov <artyom.abakumov@red-soft.ru>
dyemanov pushed a commit that referenced this pull request Jul 10, 2024
@Noremos @dyemanov
Do not delete system trace session with missing parent process (fix for
6e07e3a 
#8180) (#8179)

* Do not compact system session with missing parent process

* Replace assert with fb_assert

---------

Co-authored-by: Artyom Abakumov <artyom.abakumov@red-soft.ru>
dyemanov pushed a commit that referenced this pull request Nov 16, 2024
@Noremos @dyemanov
Do not delete system trace session with missing parent process (fix for
a33472d 
#8180) (#8179)

* Do not compact system session with missing parent process

* Replace assert with fb_assert

---------

Co-authored-by: Artyom Abakumov <artyom.abakumov@red-soft.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hvlad hvlad hvlad approved these changes

Assignees

@Noremos Noremos

Labels
component: engine fix-version: 4.0.5 fix-version: 5.0.1 fix-version: 6.0 Alpha 1 type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sometimes a trace session is terminated spontaneously
3 participants
@Noremos @hvlad @dyemanov