-
Notifications
You must be signed in to change notification settings - Fork 205
Make audio-worklet + WASM example compile with -O2 #414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make audio-worklet + WASM example compile with -O2 #414
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution, and I have some questions.
src/audio-worklet/design-pattern/wasm/wasm-worklet-processor.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Thanks for your contribution!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Build, deploy, linting steps are failing but it looks safe to merge. Approving this again to note that.
* Make audio-worklet + WASM example compile with -O2 * format fix * remove unrelated changes * Comments addressed --------- Co-authored-by: Hongchan Choi <hongchan.choi@gmail.com>
* initial commit, basic directory structure * basic directory structure * adding webfont * added the first text in the page * first UI element * knob and toggle completed * knob and toggle completed * working example * Combine sounds into a single js file * adding dropdown and revising the landing page * matrix view added * matrix view added * Add bpm-delay.js * wavetable view drafted * Add waveshaper.js * Add wavetable.js and fft.js * filename clean up * filename change * rename files and classes, and added Note class with a prototype page * Add alternative layout * Adjusting layout * added GlobalEffect class * added GlobalEffect class * added GlobalEffect class * Layout dropdown waveform * Get all wavetables in dropdown options * added Note and Sequencer class * build more stuff in prototype * color theme * wavetable selector linked * update * update css and layout * updated index for presentation * lint problem fixed * ran prettier * Make firstTime local to Note in Wavetable Synth example * Add listener to wavetable synth for autoplay * Make audio-worklet + WASM example compile with -O2 (#414) * Make audio-worklet + WASM example compile with -O2 * format fix * remove unrelated changes * Comments addressed --------- Co-authored-by: Hongchan Choi <hongchan.choi@gmail.com> * css prettified --------- Co-authored-by: Michael Wilson <mjwilson@chromium.org> Co-authored-by: Alessio Bazzica <alessio.bazzica@riverside.fm>
See the issue described at #413