Update the qunfold wrapper for composable methods #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…en version 1.4 and the upcoming version 1.5
|
Hi Alex, I also updated the documentation accordingly (which I missed when creating the PR, sorry for that). I also tested locally that everything will work perfectly with version 1.5, which I will release shortly. Hence, the PR is ready for merging as long as you do not have any further points to discuss. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adapts the qunfold wrapper for composable methods to the changes of the qunfold package between its current version 1.4 and its upcoming version 1.5.
This adaptation implements the strategy discussed in mirkobunse/qunfold#9 In particular, it moves all wrapping of qunfold to
quapy.method.composable, which thereby becomes the only place where the integration between the two packages happens. qunfold, in return, will become fully agnostic to this integration (and to QuaPy) with its upcoming version 1.5.Note that qunfold is currently not yet at version 1.5, but only at the release candidate 1.5-rc10. However, this is not an issue for this PR because the PR assumes the planned future state of version 1.5 already. This state will be equal to the one of 1.5-rc10 but with all QuaPy integrations removed. Since the present integrations are not employed, the change between 1.5-rc10 and 1.5 will be straightforward.