Skip to content

DT-6539 Logos for social media share links #5439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 20, 2025
Merged

DT-6539 Logos for social media share links #5439

merged 4 commits into from
Aug 20, 2025

Conversation

sharhio
Copy link
Contributor

@sharhio sharhio commented Jul 16, 2025

Proposed Changes

  • Uses assets already loaded and added in the manifest when available, otherwise uses static images
  • Added png versions of svg logos (more likely to show up in the preview)
  • Renamed some ambiguously named logos
  • Fixed broken hsl logo file
  • Configurations updated

Pull Request Check List

  • A reasonable set of unit tests is included
  • Console does not show new warnings/errors
  • Changes are documented or they are self explanatory
  • This pull request does not have any merge conflicts
  • All existing tests pass in CI build

Review

  • Read and verify the code changes
  • Test the functionality by running the UI locally with all popular browsers available in your platform
  • Check that the implementation matches the design, when such one is defined in a Jira issue
  • Merge the pull request

Copy link
Member

@vesameskanen vesameskanen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Images seem to live in 2 folders: configurations/images and static/img. UI suggest using a single consistent folder.

@sharhio
Copy link
Contributor Author

sharhio commented Aug 18, 2025

Images seem to live in 2 folders: configurations/images and static/img. UI suggest using a single consistent folder.

Sure. In that case all of the images will have to be in the static/img as the build refuses to include some of the images in the manifest for unknown reasons.

Copy link
Member

@vesameskanen vesameskanen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for overlooking this before, but I just checked how UI loads various assets:

  • geojson files are loaded via CDN
  • favicons seem to come from UI server directly
  • static/img/nearby-stop_animation.gif (shown in empty nearest fav tab) is loaded directly from UI server
  • svg asssets seem to load from url 'data:image/svg+xml', I don't know how that works out

I guess we have to carefully avoid moving more asset loading away from CDN. Maybe it only means that img folder needs to go under assets folder? Could you verify this?

I am not sure if we have to start using versioned names when using CDN, just like with geojson files. Browsers might cache files such as 'citylogo.png' anyway, so CDN might not play any role in naming.

@vesameskanen vesameskanen merged commit 5c6159d into v3 Aug 20, 2025
6 checks passed
@vesameskanen vesameskanen deleted the DT-6539 branch August 20, 2025 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants