Warning fixes #177
Open
Warning fixes #177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Fixed warning realted to zero-iniliazation of first member by repacing with brace-iniliazation i.e. valid for C++ 11 onwards. 2. There is an empty for loop for no apperent reason. Nevetheless added a prefix [[maybe_unused]] to avoid warning. 3. Added constexpr in the declaration of MAX_SAFE_STACK used to define constant length array but C++ thinks its variable length array without MAX_SAFE_STACK being constexpr. 4. The function type2bytes of return type size_t had no return outside if confition, added a return 0 at the end of the function. 5. Not all fields were being initialized for a vector syncs_ of type ec_sync_info_t. Added all fields. 6. Avoided narrowing conversions from 64-bit size_t to 32-bit unsigned int, by explicitly casting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have fixed all the warnings that show up during colcon build.