-
Notifications
You must be signed in to change notification settings - Fork 3
Periodic messages #39
base: master
Are you sure you want to change the base?
Conversation
Code Climate has analyzed commit a232535 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 74.3% (80% is the threshold). This pull request will bring the total coverage in the repository to 89.6% (-3.5% change). View more on Code Climate. |
Codecov Report
@@ Coverage Diff @@
## master #39 +/- ##
==========================================
+ Coverage 81.42% 85.98% +4.56%
==========================================
Files 6 7 +1
Lines 280 364 +84
Branches 22 26 +4
==========================================
+ Hits 228 313 +85
+ Misses 45 42 -3
- Partials 7 9 +2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adiciona testes automatizados à sua função nova, não consegui testar manualmente na minha máquina
# Conflicts: # .gitignore # bot/application.py
users_custom_invervals.json.zip |
@williamsimiao , onde o arquivo "users_custom_invervals.json" é criado? |
chatID = update.message.chat_id | ||
if (intervals_dic.get(str(chatID) is not None)): | ||
interval = int(intervals_dic.get(str(chatID))) | ||
except FileNotFoundError: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
é preciso criar o arquivo uma vez não encontrado
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Arquivo sendo criado no ultimo commit
bot/application.py
Outdated
|
||
def callback_lets_talk(self, bot, job): | ||
bot.send_message(chat_id=job.context.message.chat_id, | ||
text='Vamos conversar ?') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
só remover o espaço entre conversar
e ?
@williamsimiao esta PR foi criada dia 30 de julho, atualiza ela e conserta as revisões! |
19c6557
to
bda3e05
Compare
…ecov errors with more tests
# Conflicts: # bot/application.py
PR Description
Adiciona a funcionalidade de mensagens enviadas pelo bot a fim de lembrar o usuário de conversar com o bot. O usuário pode determinar o intervalo, em dias, que deseja receber esse lembrete usando o comando \lembrete.
New Feature Submissions
To run tests locally, use
make
if you're on Mac or Linux.New Dialog Submissions
User messages have
- -
, bot messages have-
test_dialogs
?Changes to Core Features