change dict to list to respect order #615
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
longshuicy
requested review from
ylyangtw,
Rashmil-1999,
navarroc and
ywkim312
navarroc
approved these changes
Sep 19, 2024
ywkim312
approved these changes
Sep 19, 2024
ywkim312
deleted the
614-created-hazard-rasters-files-doesnt-follow-the-demand-type-orders
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Anibal reported that when uploading the hurricane rasters with multiple demand types to the Incore services, the returned hazard intensity values differ from the local results. Upon investigation, I found that the order of the files, which should correspond to the demand types, was not being preserved due to the use of a dictionary. I have updated the implementation to use a list instead, which should resolve the issue.
To Test:
Run the pytest or monitor the GitHub Action to ensure it passes.