Skip to content

Conversation

ywkim312
Copy link
Member

@ywkim312 ywkim312 commented May 15, 2025

Please test this PR by running the test file tests/pyincore/analyses/mlenabledcgemobile/test_mlcgemobile.py

Here's the new datasets for this PR

Mobile Building to Sector Dataset
dev: 68487858d11a287c7c375f4d
prod: 684877df9af67e766267ead7

Mobile Building Inventory Ver 7
dev: 682756c3ce15ce6bdf996b22
prod: 6827560d1d2b050c74df1526

Mobile Building Sector Shock
dev: 68434532d11a287c7c34a64a
prod: 684345c99af67e7662654b36

  • Validated with CGE team

@ywkim312 ywkim312 linked an issue May 15, 2025 that may be closed by this pull request
@ywkim312 ywkim312 self-assigned this May 15, 2025
@ywkim312 ywkim312 changed the title 658 implement ml enabled cge mobile 658 implement ml enabled cge Mobile May 16, 2025
@ywkim312 ywkim312 marked this pull request as ready for review June 10, 2025 19:42
@navarroc
Copy link
Member

Once we get confirmation from the research team, I think we can merge this. However, we'll need to fix the conflict first.

Copy link
Member

@longshuicy longshuicy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test finished and results looks reasonable.
Have we got a confirmation from the research team already? Approving for now.

@longshuicy longshuicy merged commit 5f9c03d into develop Jul 29, 2025
7 checks passed
@longshuicy longshuicy deleted the 658-implement-ml-enabled-cge---mobile branch July 29, 2025 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement ML Enabled CGE - Mobile
4 participants