-
Notifications
You must be signed in to change notification settings - Fork 9
658 implement ml enabled cge Mobile #665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+872
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Once we get confirmation from the research team, I think we can merge this. However, we'll need to fix the conflict first. |
longshuicy
approved these changes
Jul 29, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test finished and results looks reasonable.
Have we got a confirmation from the research team already? Approving for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please test this PR by running the test file tests/pyincore/analyses/mlenabledcgemobile/test_mlcgemobile.py
Here's the new datasets for this PR
Mobile Building to Sector Dataset
dev: 68487858d11a287c7c375f4d
prod: 684877df9af67e766267ead7
Mobile Building Inventory Ver 7
dev: 682756c3ce15ce6bdf996b22
prod: 6827560d1d2b050c74df1526
Mobile Building Sector Shock
dev: 68434532d11a287c7c34a64a
prod: 684345c99af67e7662654b36