Skip to content

[WIP] feat(neighbors): add neighbors transforms (in/out) #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

nathandebalthasar
Copy link

This pull request implements the initial part of Add transforms related to transactions and neighbors #10.

Currently, only the "To input addresses" transform has been implemented. Is this in line with what you had in mind?

While testing, I noticed that the Tatum transform only retrieves the first 25 input addresses. For example, when querying the default BTC address created in Maltego using the Blockchain.com Explorer, there are dozens of pages of input addresses available. However, the Tatum transform seems to return only the first page.

While trying to implement this functionality using the GraphSense Python API wrapper, I encountered issues with pagination. According to the documentation, the list_address_neighbors method should support pagination via page and pagesize parameters. However, the method only returns an object with the neighbors key, and regardless of the parameters provided, it never returns pagination data such as next_page.

As a result, the API call can take a very long time to execute (I waited up to one minute before cancelling the request).

To address this issue, I believe we have two options:

  • Wait for the GraphSense team to fix their API or confirm the expected behavior

  • Bypass the Python API wrapper and make raw HTTP requests directly to the API

On another note, I also noticed that the Tatum input addresses transform does not take into account change addresses. For example, if an address A sends 0.3 BTC but there is a change address and only 0.2 BTC is sent to address B, Tatum will add the input address and indicate that the amount sent to address B is 0.3 BTC even if there is a change address. Is it the expected behavior?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant