-
Notifications
You must be signed in to change notification settings - Fork 3
Simulation bridge event based architecture #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@marcomelloni The PR seems to improve the bridge. But I have some concerns about the structuring of the code. The design of Telegraf is a good reference. The bridge has three input protocol adopters (RabbitMQ, MQTT, REST), one output protocol (RabbitMQ) adopter. If you look into the plugin design for Telegraf codebase and plugin development, it is likely to improve the bridge as well.
Thanks in advance for improving it.
@marcomelloni also if you can take care of manageable sonarcube issues along the way, it does not become additional work later. |
I’ve addressed all the comments. |
@marcomelloni the following error appears for the packaged simulation_bridge
|
Never mind. It is my mistake. I should have used |
The add |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes the existing simulation clients, test scripts, and the previous RabbitMQ‐based bridge implementation to prepare for a new event-based architecture.
- Removed legacy simulation client code and Matlab/Python simulation scripts under
tests/simulations
- Deleted the old Digital Twin RabbitMQ client in
tests/dt
- Cleaned out the entire
src/simulation_bridge
module along with its unit and integration tests and docs
Reviewed Changes
Copilot reviewed 81 out of 102 changed files in this pull request and generated no comments.
File | Description |
---|---|
tests/simulations/simulation_client_rabbitmq.py | Deleted legacy RabbitMQ simulation client |
tests/simulations/python/simulator.py | Deleted old Python MQTT simulator |
src/simulation_bridge/simulation_bridge.py | Removed previous bridge core classes and handlers |
src/simulation_bridge/README.md | Cleared out outdated documentation |
Comments suppressed due to low confidence (3)
|
No description provided.