Skip to content

Github Actions #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Jul 10, 2025
Merged

Github Actions #27

merged 20 commits into from
Jul 10, 2025

Conversation

marcomelloni
Copy link
Collaborator

@marcomelloni marcomelloni commented Jul 10, 2025

This pull request introduces new CI workflows for the MATLAB Agent and Simulation Bridge projects, while also deprecating an older workflow for Simulation Bridge tests. Additionally, it updates the pytest.ini configuration to include code coverage reporting. These changes aim to streamline CI processes and enhance test reporting.

CI Workflow Additions:

CI Workflow Deprecation:

Test Configuration Update:

  • pytest.ini: Updated pytest settings to enable coverage reporting, including branch coverage and XML output for integration with tools like Codecov.

Copy link

codecov bot commented Jul 10, 2025

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@prasadtalasila
Copy link
Contributor

@marcomelloni Some suggestions:

  1. Please have separate github actions for Matlab and Simulation Bridge. For example, see different workflows and one workflow. The trick is to trigger a workflow only if changes happen in certain directories.
  2. Run the unit and integration tests. The Matlab specific tests can be skipped of course.
  3. Upload artifacts (whl and zip files). The results of poetry build can be uploaded to the build page. Please see this example and this can be done at the end of each workflow file.
  4. It is probably better to consolidate the three action files into one. The sequence of checks could be formatting, linting, testing, coverage reporting, building and uploading artifacts.

poetry build --format sdist

- name: Upload dist artefacts
uses: actions/upload-artifact@v4
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remember to set expiration time of one hour for the artifacts.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One hour isn’t supported, so the shortest possible setting is 1 day

@prasadtalasila
Copy link
Contributor

@marcomelloni Please copy the simulation-bridge-ci.yml into matlab-agent-ci.yml and adapt it for Matlab Agent. Thanks.

@marcomelloni
Copy link
Collaborator Author

.github/workflows/matlab-agent-ci.yml I added a new CI workflow for the MATLAB Agent, excluding tests and the uploading in codecov.

.github/workflows/simulation-bridge-ci.yml It's now one-single job. I set expiration time of one day for the artifacts because one hour isn’t supported

Copy link

@prasadtalasila prasadtalasila merged commit 3b9ecdc into main Jul 10, 2025
9 checks passed
@marcomelloni marcomelloni deleted the github-actions branch July 10, 2025 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants