Update lkauto #28
Merged
Update lkauto #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Catnatsuki
commented
Jun 19, 2025
Catnatsuki
commented
- Updated lkauto to work with the latest version of lenskit and other libraries.
- Updated the unit tests to reflect the changes from point 1.
- Updated the workflow file to run the tests to also reflect the changes from points 1 and 2.
… Lenskit Datasets. Also updated the requirements in setup.py to use smac 2.3 and numpy >2.2
… Iterator[TTSplit]) as data. Also updated some imports in bayesian_optimization.py, implicit_evaler.py and lkauto.py
… correct) Also updated the ExplicitEvaler construction calls in the other files
…train and ItemListCollection for validation (also updated function calls accordingly)
…ataset format, if the dataset has a different format it could lead to errors again
…ADME.md. Deleted old code from bayesian_optimization.py
test_get_model_from_cs.py passes some tests Updated get_default_configurations.py
…rameters as instance variables to get acceded while testing. + mini update for the test file. Test is OK
…racted from my functioning environment
…value for damping + Test for svd is now OK
…used by lenskit. Updated related tests to make sure they are working.
…in the config space.
changed python version to 3.11
Changed python version to 3.12 to match lenskit requirements.
…ult_configurations.py since new versions of some algorithms don't support both feedback types anymore
…emItem instead of ItemKNNScorer), since these names are used everywhere else and the new names broke the program (+ updating their tests). Also added feedback type as optional parameter to algorithm constructors
tobiasvente
approved these changes
Jul 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.