Skip to content

♻️ repo cleanup and doc #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 34 commits into from
Aug 29, 2024
Merged

Conversation

pcrespov
Copy link
Member

@pcrespov pcrespov commented Aug 27, 2024

What do these changes do?

After reviewing the repo structure and the release workflow, I did the following changes:

  • Reorganized and doc the repository to resemble osparc-simcore layout
  • Started migration to pyproject.toml (limited by dynamic setup of versioning)
  • Added .vscode config templates
  • Updated Makefiles

@Konohana0608 just FYI: this PR will still not bring the changes you need in the API.

Related issue/s

How to test

For internal developers

@pcrespov pcrespov self-assigned this Aug 27, 2024
@pcrespov pcrespov changed the title WIP: ♻️ Is1611/cleanup ♻️ repo cleanup and doc Aug 28, 2024
@pcrespov pcrespov added this to the Eisbock milestone Aug 28, 2024
@pcrespov pcrespov marked this pull request as ready for review August 28, 2024 15:13
@pcrespov pcrespov enabled auto-merge (squash) August 28, 2024 15:13
@pcrespov pcrespov disabled auto-merge August 28, 2024 15:37
@pcrespov pcrespov requested a review from Konohana0608 August 28, 2024 15:56
@pcrespov pcrespov enabled auto-merge (squash) August 28, 2024 15:57
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Be careful with ignoring imports with mypy. That is exactly how you get into many issues

Copy link

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice thank you! yes when we consolidate things now its easier to jump in and help 👍

@pcrespov pcrespov merged commit 6c4e055 into ITISFoundation:master Aug 29, 2024
8 checks passed
@pcrespov pcrespov deleted the is1611/cleanup branch August 29, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants