-
Notifications
You must be signed in to change notification settings - Fork 5
✨ Add program section to client #226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Add program section to client #226
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
clients/python/test/test_osparc/test_apis.py:48
- [nitpick] The parameter name 'job_inpus' appears to be a misspelling; consider renaming it to 'job_inputs' for clarity.
side_effect=lambda solver_key, version, job_inpus, **kwargs: check_headers(**kwargs)
@@ -164,7 +243,7 @@ async def upload_file_async( | |||
iter(client_upload_schema.upload_schema.urls), start=1 | |||
) | |||
n_urls: int = len(client_upload_schema.upload_schema.urls) | |||
if n_urls < math.ceil(file.stat().st_size / chunk_size): | |||
if n_urls < math.ceil(client_file.actual_instance.filesize / chunk_size): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The variable 'client_file' is referenced here even though it was renamed to 'user_file' in the earlier part of the function. Please update the reference to 'user_file' for consistent naming.
Copilot uses AI. Check for mistakes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Q: this goes directly on the tutorials/doc?
Already done by previous merges |
What do these changes do?
Related issue/s
How to test
For internal developers