Skip to content

✨ Add program section to client #226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

bisgaard-itis
Copy link
Collaborator

@bisgaard-itis bisgaard-itis commented Mar 31, 2025

What do these changes do?

  • Update client to also handle programs.

Related issue/s

How to test

For internal developers

@bisgaard-itis bisgaard-itis self-assigned this Mar 31, 2025
@bisgaard-itis bisgaard-itis added the enhancement New feature or request label Mar 31, 2025
@bisgaard-itis bisgaard-itis added this to the The Awakening milestone Mar 31, 2025
@bisgaard-itis bisgaard-itis marked this pull request as ready for review April 17, 2025 05:51
@bisgaard-itis bisgaard-itis requested a review from pcrespov as a code owner April 17, 2025 07:29
@pcrespov pcrespov requested a review from Copilot April 17, 2025 07:45
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

clients/python/test/test_osparc/test_apis.py:48

  • [nitpick] The parameter name 'job_inpus' appears to be a misspelling; consider renaming it to 'job_inputs' for clarity.
side_effect=lambda solver_key, version, job_inpus, **kwargs: check_headers(**kwargs)

@@ -164,7 +243,7 @@ async def upload_file_async(
iter(client_upload_schema.upload_schema.urls), start=1
)
n_urls: int = len(client_upload_schema.upload_schema.urls)
if n_urls < math.ceil(file.stat().st_size / chunk_size):
if n_urls < math.ceil(client_file.actual_instance.filesize / chunk_size):
Copy link
Preview

Copilot AI Apr 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The variable 'client_file' is referenced here even though it was renamed to 'user_file' in the earlier part of the function. Please update the reference to 'user_file' for consistent naming.

Copilot uses AI. Check for mistakes.

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Q: this goes directly on the tutorials/doc?

@bisgaard-itis
Copy link
Collaborator Author

Already done by previous merges

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants