Skip to content

New openapi.json with functions ✨ #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 28, 2025

Conversation

wvangeit
Copy link
Contributor

What do these changes do?

Update openapi.json to latest from simcore master.
@pcrespov if I understand you correctly yesterday, we could already commit this into master here?

@wvangeit wvangeit added this to the Bazinga! milestone May 20, 2025
@wvangeit wvangeit self-assigned this May 20, 2025
@wvangeit wvangeit added the enhancement New feature or request label May 20, 2025
@pcrespov
Copy link
Member

@pcrespov if I understand you correctly yesterday, we could already commit this into master here?

@wvangeit yes, i think that should be the case. Double check the github actions to be sure what will happen
i do not fully recall all details.

@bisgaard-itis
Copy link
Collaborator

bisgaard-itis commented May 28, 2025

Update

@pcrespov @wvangeit
In order to make the tests pass here I had to do the following changes

  • I had to use the openapi generator docker image tagged latest-release because there seems to be a bug in the latest. As a consequence, the wheel for the osparc_client would not build.
  • I had to upgrade a bunch of the github actions because the versions we used are retired
  • I had to remove the tests on Ubuntu 20.04 because that runner is retired.
  • The new openapi specs change the id of one of the endpoints. As a consequence the function name in osparc_client changed. Meaning this is not backwards compatible. However, I made a change in osparc so that that package is backwards compatible.

@bisgaard-itis bisgaard-itis merged commit ff69213 into ITISFoundation:master May 28, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants