Refactor to gtk4 with all #1108
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: The `angle` config option has been removed. You can now control text angle from CSS. BREAKING CHANGE: Popups now use the native GTK popover widget, rather than a separate window. Styles will need updating. Co-authored-by: pinklifeart <dev@pinklab.cloud>
tglman
force-pushed
the
refactor-gtk4-all
branch
from
654d779 to
a62b799
Compare
|
I tried it and it's pretty great. I have some weird bugs though occasionally when a popup at [[end]] moves to the right an off the screen. |
|
Also, tray support would be the killer feature to have. Great work otherwise ! |
|
Hi @werdahias, The tray should work, do you have any issues ? |
|
@tglman nice, didn't realize this was already possible, the wiki stated it was still WIP. Just enabled it, very happy so far! Cheers, eh! |
|
The wiki reflects the state of the "stable" port #112, which does not include some modules that still have PRs open for their ports. This PR is just to tie that all together in the meantime for convenience if anybody wants to try the unstable features. I'm hoping to pick the remaining module PRs up and re-review/test in the near future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I did merge together #1043 and #1029 and rebased on top of the current master, it mostly works except right now has some issues with the launcher module that I'm checking.
I'm opening this just to give an heads up that this work is done and if someone what to test it is more than welcome.
This also port the new module menu to gtk-4.
I will try to keep this branch update with master to remove the potential merge conflicts.