One icon per connection type in NetworkManager module #690
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 33f73ee.
(cherry picked from commit 1c33b3b)
JakeStanger
added
M:Network Manager
# Conflicts: # Cargo.lock # Cargo.toml # src/clients/networkmanager.rs # src/modules/networkmanager.rs # src/modules/volume.rs
An extensive refactor of the multiple icons features, containing the following changes: - Reflect the changes in module UI and client interfaces to the rest of Ironbar - Replace state-based communication from client to UI with an event-based one - D-bus device watching rewritten without the use of macros - Defining which types of devices get an icon now takes place in the UI code
|
Commit Before I'll mark this PR as ready for review I will implement support for showing the wifi signal strength, and consider what the configuration should look like. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft PR to track the status of the implementation. Will watch all NM connections and figure out if they should be categorised as ethernet, wifi, cellular, VPN or other. If there is at least one connection in a category, an icon will be shown for it indicating its status in more detail.