Skip to content

Add UT for Data and Scorers library #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 30 commits into from
Dec 27, 2024
Merged

Add UT for Data and Scorers library #26

merged 30 commits into from
Dec 27, 2024

Conversation

SecroLoL
Copy link
Contributor

Add unit tests for the data/ and scorers/ dirs.

Make some small bugfixes after discovering malfunctions during testing.

SecroLoL and others added 27 commits December 23, 2024 16:06
…display_meter and make schema enforcement prompt use the actual type of the object instead of the raw name.
Copy link
Collaborator

@JCamyre JCamyre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM nice unit tests

… tests because pytest was trying to use it as a Test class, but it can't because TestScorer inherited from a real class (with an __init__).
Copy link
Collaborator

@JCamyre JCamyre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after fixing minor issues.

Copy link
Collaborator

@JCamyre JCamyre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add Tracer UT fixes from other PR

@JCamyre JCamyre merged commit 6e34acb into main Dec 27, 2024
2 checks passed
@SecroLoL SecroLoL deleted the alex/add-unit-tests branch December 30, 2024 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants