Add trace ID to datasets, update UTs accordingly #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g csv's using pandas.
JCamyre
approved these changes
Dec 31, 2024
|
|
||
| The JSON file is expected to have the following format: | ||
| { | ||
| "ground_truths": [ |
There was a problem hiding this comment.
What does ground truths mean in relation to the examples, I thought the examples has the ground truth (with the actual_output field)
| @@ -195,17 +252,21 @@ def add_from_csv( | |||
| "Please install pandas to use this method. 'pip install pandas'" | |||
| ) | |||
|
|
|||
| df = pd.read_csv(file_path) | |||
| df = pd.read_csv(file_path, dtype={'trace_id': str}) | |||
There was a problem hiding this comment.
What else can dtype be?
A trace_id or trace_file?
There was a problem hiding this comment.
Pandas naturally reads numbers in data files as ints, not strings (can lead to unexpected behavior)
| "ground_truths": [ | ||
| { | ||
| "input": "test input", | ||
| "actual_output": null, |
There was a problem hiding this comment.
Is the difference between ground_truths and examples that ground_truths don't have an actual_output (this is for the LLM system to produce)
JCamyre
approved these changes
Dec 31, 2024
…add_trace_to_datasets
…ues are resolved and now UTs pass.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When adding the
trace_idfield toExamples, I forgot to add them toEvalDatasets as well. This PR takes care of that issue and also updates the UTs for theEvalDatasetclass accordingly.