Skip to content

add: TestTraceOperations for trace-related functionality #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 18, 2025

Conversation

jack-devhub
Copy link
Contributor

Changes

  • Added a new test case in src/e2etests/judgment_client_test.py that makes a request to the endpoint and asserts the expected response.
  • Ensured the test runs as part of the existing test suite.

Testing

  • Ran the test locally to confirm it executes successfully.
  • Verified the endpoint response matches expectations.

@JCamyre
Copy link
Collaborator

JCamyre commented Feb 13, 2025

Were your tests able to pass when you ran them? My tests failed even when I added the eval_complete column to the traces table in the Supabase.
It seems your .gte("created_at", f"now()-{hours}h") # PostgreSQL interval notation is causing issues.

postgrest.exceptions.APIError: {'code': '22007', 'details': None, 'hint': None, 'message': 'invalid input syntax for type timestamp: "now()-1h"'}

Did you mean to add this code only after you update the traces table to be a time series DB?

@jack-devhub
Copy link
Contributor Author

Were your tests able to pass when you ran them? My tests failed even when I added the eval_complete column to the traces table in the Supabase. It seems your .gte("created_at", f"now()-{hours}h") # PostgreSQL interval notation is causing issues.

postgrest.exceptions.APIError: {'code': '22007', 'details': None, 'hint': None, 'message': 'invalid input syntax for type timestamp: "now()-1h"'}

Did you mean to add this code only after you update the traces table to be a time series DB?

Updated the code into the judgment and resolved the time error as well as the query.

Copy link
Collaborator

@JCamyre JCamyre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Run UT's

@JCamyre JCamyre merged commit 413f68c into main Feb 18, 2025
3 checks passed
@JCamyre JCamyre deleted the add_e2e_judgment_client_test branch April 18, 2025 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants