Skip to content

Pretty print trace URL in CLI #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 16, 2025
Merged

Pretty print trace URL in CLI #72

merged 2 commits into from
Feb 16, 2025

Conversation

alanzhang25
Copy link
Collaborator

No description provided.

Copy link
Collaborator Author

@alanzhang25 alanzhang25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Run UT

data = entry.to_dict()
assert data["output"] is None
data = entry.to_dict()
assert data["output"] == non_serializable.__str__()
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is to fix: #71

Copy link
Collaborator

@JCamyre JCamyre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@JCamyre JCamyre merged commit a84f003 into main Feb 16, 2025
7 checks passed
@alanzhang25 alanzhang25 deleted the az-trace-cli-url branch March 25, 2025 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants