Remove duplicate saving of trace #90
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hello @alanzhang25, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
This pull request aims to remove duplicate saving of trace data. Currently, the code saves trace data using self.trace_manager_client.save_trace and then proceeds to save the same data again by making a POST request to the JUDGMENT_TRACES_SAVE_API_URL. This PR removes the second, redundant saving mechanism, relying solely on the trace_manager_client.
Highlights
- Duplicate Trace Saving: The code was saving trace data twice, once via
trace_manager_clientand again via a direct API POST request. - Redundancy Removal: This PR removes the direct API POST request, eliminating the duplicate saving of trace data.
Changelog
- src/judgeval/common/tracer.py
- Removed the redundant POST request to
JUDGMENT_TRACES_SAVE_API_URLfor saving trace data. - The trace data is now saved only using
self.trace_manager_client.save_trace.
- Removed the redundant POST request to
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
A trace is laid, a path defined,
But saving twice? A waste of time!
With client's call, the deed is done,
The extra post? Now there are none.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
The pull request removes a duplicate saving of trace data by removing the direct POST request to the API, relying instead on the trace_manager_client.save_trace method. This change aims to prevent redundant data storage and streamline the trace saving process. The removal of the duplicate save operation is a good step towards optimizing the tracing system.
Merge Readiness
The change appears straightforward and addresses the issue of duplicate trace saving. Since there are no review comments, I believe the code is in good shape to be merged. However, I am unable to directly approve the pull request, and I recommend that others review and approve this code before merging.
No description provided.