fix header #91
fix header #91
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hello @alanzhang25, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
This pull request addresses an issue with the headers being sent in the judgeval application. Specifically, it adds the X-Organization-Id header to the save_trace function and removes the judgment_api_key from the JSON payload of the delete_trace function. This ensures that the organization ID is included when saving traces and that the API key is not unnecessarily sent when deleting traces.
Highlights
- Header Addition: The
X-Organization-Idheader is added to thesave_tracefunction to include the organization ID in the request. - Payload Modification: The
judgment_api_keyis removed from the JSON payload of thedelete_tracefunction.
Changelog
- src/judgeval/common/tracer.py
- Added
X-Organization-Idheader to thesave_tracefunction (line 231). - Removed
judgment_api_keyfrom the JSON payload of thedelete_tracefunction (line 249).
- Added
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
A header's missed, a key's misplaced,
The API call, a bit disgraced.
With careful fix, and code so neat,
The traces flow, complete, discrete.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
The pull request introduces a new header X-Organization-Id to the save_trace and fetch_trace methods, and removes judgment_api_key from the delete_trace method. These changes seem reasonable for improving security and organization within the tracing system. However, I have a few questions regarding the removal of judgment_api_key from the delete_trace method.
Summary of Findings
- Redundant API Key: The
judgment_api_keyis being removed from the request body of thedelete_tracemethod, but it is still present in the headers. Is this intentional? If so, please provide a comment explaining why it is no longer needed in the request body.
Merge Readiness
The code changes seem reasonable, but I have a question regarding the removal of judgment_api_key from the delete_trace method. I would recommend addressing this before merging. I am unable to approve this pull request, and users should have others review and approve this code before merging.
| json={ | ||
| "judgment_api_key": self.judgment_api_key, | ||
| "trace_ids": [trace_id], |
There was a problem hiding this comment.
The judgment_api_key is being removed from the request body, but it is still present in the headers. Is this intentional? If so, please provide a comment explaining why it is no longer needed in the request body.
No description provided.