add new header #94
add new header #94
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hello @alanzhang25, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
This pull request adds the X-Organization-Id header to the edit_dataset and export_jsonl methods in the eval_dataset_client.py file. This header is included in the requests made to the Judgment Datasets API, along with the existing Content-Type and Authorization headers. The goal is to ensure that the organization ID is properly passed when editing or exporting datasets.
Highlights
- Header Addition: The
X-Organization-Idheader is added to API requests inedit_datasetandexport_jsonl. - API Communication: Ensures the organization ID is included in requests to the Judgment Datasets API.
Changelog
- src/judgeval/data/datasets/eval_dataset_client.py
- Added
X-Organization-Idheader to theedit_datasetmethod's request headers. - Added
X-Organization-Idheader to theexport_jsonlmethod's request headers.
- Added
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Did you know?
HTTP headers are case-insensitive, meaning Content-Type is treated the same as content-type or CONTENT-TYPE.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
The pull request adds the X-Organization-Id header to the edit_dataset and export_jsonl functions in the EvalDatasetClient class. This change ensures that the organization ID is included in the requests to the Judgment API, which is necessary for proper authorization and data isolation. The changes look good overall.
Merge Readiness
The pull request is ready to be merged. The addition of the X-Organization-Id header to the edit_dataset and export_jsonl functions enhances the security and functionality of the EvalDatasetClient class. I am unable to approve this pull request, and users should have others review and approve this code before merging.
No description provided.